Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: port the security patches we have for CVEs #165

Merged
merged 1 commit into from Sep 10, 2020

Conversation

TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Sep 10, 2020

Instead of running on its own site, it now integrates with the
main website. This avoids copying the Jekyll website and maintaining
two instances of it. The main website and the CVE listing are similar
enough that this shouldn't be an issue.

The data is imported from the current security listing we have,
including the patches available. It is imported as-is without
modification.

NOTE : when reviewing, please run the Docker locally and test out if it is all what it should be.

Why via Docker and not via Jekyll serve? Otherwise .patch files will download, instead of showing it inline. Makes it a tiny bit harder to see what is going on.

The "diff" has a few files before all the _security related files start, and ends with 3 non-_security files at the bottom. Keep that in mind when reviewing.

Instead of running on its own site, it now integrates with the
main website. This avoids copying the Jekyll website and maintaining
two instances of it. The main website and the CVE listing are similar
enough that this shouldn't be an issue.

The data is imported from the current security listing we have,
including the patches available. It is imported as-is without
modification.
Copy link
Member

@LordAro LordAro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit. Pushing to staging so we can actually test it!

@TrueBrain TrueBrain merged commit df3627e into OpenTTD:master Sep 10, 2020
@TrueBrain TrueBrain deleted the security branch September 10, 2020 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants