Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

verilator: 4.040 -> 4.100 #98109

Merged
merged 1 commit into from Sep 16, 2020
Merged

verilator: 4.040 -> 4.100 #98109

merged 1 commit into from Sep 16, 2020

Conversation

Pamplemousse
Copy link
Member

Motivation for this change

Update to newer version; Actually builds now.
ZHF: #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Pamplemousse
verilator: 4.040 -> 4.100
9839c0b 
Signed-off-by: Pamplemousse <xav.maso@gmail.com>
@ofborg ofborg bot requested a review from thoughtpolice September 16, 2020 16:06
@thoughtpolice
Copy link
Member

I literally have no idea what broke this package; as you can see here it was building fine with 4.040 when I committed it. Sigh...

Thank you for the update, I appreciate it.

@thoughtpolice thoughtpolice merged commit f1f1396 into NixOS:master Sep 16, 2020
@risicle
Copy link
Contributor

risicle commented Sep 16, 2020

WFM macos 10.14 ohtoolate

@Pamplemousse Pamplemousse deleted the verilator branch September 16, 2020 21:14
@Pamplemousse Pamplemousse mentioned this pull request Sep 18, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice thoughtpolice approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Pamplemousse @thoughtpolice @risicle