New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always pass --enable-chrome-logs for Chromedriver #25540
Conversation
@Hexcles - WDYT? I pushed a full trigger run and had a poke through the logs to see if anything blew up; we definitely do get some additional logs but not a huge amount so maybe that's fine? I think it would be nice for folks to get logs both (a) in the stability checks and (b) when running locally without them doing anything, we just need to balance it off against the risk of Chrome spamming our CI logs into submission :D. |
The verbosity might be OK (I'm a bit on the fence here), but I'd like to at least tell Chrome logs apart from runner logs more easily, e.g. adding a prefix to logs (I know right now we can filter by "pid:" but that seems a bit brittle and not obvious). Perhaps we can put Chrome logs into a log file as an artifact instead? |
I'm not sure if we want to do that, as it then becomes hard to find where one test ends and another begins (unless we also dump information on that to the log). I think there's two main angles we want to cover here:
If we think always-on is too spammy, then I would propose we go forward by turning this flag on for stability checks specifically (as they tend to be the most likely CI that a dev is looking at), and otherwise instruct developers to pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Stephen! I'm convinced that we want browser logs included by default; in other words, I'm not worried about the verbosity any more.
Going back to my other point about interleaving two kinds of logs, I agree that splitting Chrome logs into a seperate file defeats the purpose, so it seems the best way is to prefix the runner logs and/or the browser logs, but I'm fine with leaving that as a future improvement.
That would be done in
We'd probably have to change the data itself, by prefixing something to the |
…#25540) This enabled Chrome log output both for developers working locally, as well on the CI (where we have had frequent complaints about a lack of output, especially for crashes). The hope is that it will not be too spammy, but we will need to see how that goes.
Passing an async function to async_test will soon be disallowed in WPT, as any asserts thrown will be turned into unhandled promise rejections and the test will timeout. If a test needs async functions it should use promise_test instead - however in this case the tests don't actually need async functions (they don't use await or rely on promises). Bug: web-platform-tests/wpt#25540 Change-Id: I9be1f0b89350b611ed7db260e9ec5b79def03305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414758 Reviewed-by: vmpstr <vmpstr@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#807916} GitOrigin-RevId: c3d8da07b7440faba7a74a48c720ee423d51f4f9
No description provided.