allowpaymentrequest was deprecated #25559
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
This has merge conflicts, so needs to be rebased. Also need to decide if the Task Cluster failures are false positives or instead real problems that needs to be fixed —
- https://github.com/web-platform-tests/wpt/pull/25559/checks?check_run_id=1121417544
- https://github.com/web-platform-tests/wpt/pull/25559/checks?check_run_id=1121417665
That sink-task failure doesn’t look familiar…
marcoscaceres
force-pushed
the
allowpaymentrequest-feature-policy
branch
from
4bc377d
to
ba03d4c
Compare
|
Fixed merge conflicts. Thanks @sideshowbarker for letting me know! |
|
actually, it's not worth merging this anymore... it's literally changing whitespace, so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing "allowpaymentrequest" from feature-policy related tests