Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opencl-info: fix build #98054

Merged
merged 1 commit into from Sep 30, 2020
Merged

opencl-info: fix build #98054

merged 1 commit into from Sep 30, 2020

Conversation

demyanrogozhin
Copy link
Member

Motivation for this change

The build of opencl-info recently started failing because opencl-clhpp was
updated. The latest version of opencl-hpp does not ship the deprecated
cl.hpp header anymore.

ZHF: #97479

Things done

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)

  • Built on platform(s)

    • NixOS
    • macOS
    • other Linux distributions

  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)

  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"

  • Tested execution of all binary files (usually in ./result/bin/)

  • Determined the impact on package closure size (by running nix path-info -S before and after)

  • Ensured that relevant documentation is up to date

  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from abbradar September 15, 2020 17:49
jonringer
jonringer reviewed Sep 15, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's nothing nixos-specific in this, please upstream the changes so that it's in a better state

@demyanrogozhin
Copy link
Member Author

Created marchv/opencl-info#2. TBH not sure would it be merged upstream as opencl-info didn't see any updates for 6 years.

@danieldk
Copy link
Contributor

danieldk commented Sep 17, 2020 •
edited

If opencl-info is unmaintained, we could also consider dropping it. We also have clinfo, which provides similar functionality and is maintained:

https://github.com/Oblomov/clinfo

@demyanrogozhin
Copy link
Member Author

demyanrogozhin commented Sep 17, 2020 •
edited

@danieldk ethash and ethminer depends on opencl-info, but also first builds well w/o opencl-info dependency and second marked as broken.

@danieldk
Copy link
Contributor

@danieldk ethash and ethminer depends on opencl-info

I wonder where any of the dependencies for ethash come from? It builds fine when removing all of the buildInputs, and the source code does not seem to contain any references to Boost or OpenCL.

cc @nand0p

@risicle
Copy link
Contributor

risicle commented Sep 26, 2020

Where are we with this then? This builds for me (non-nixos linux x86_64) and there are a number of reverse-dependencies stuck on it.

danieldk
danieldk approved these changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't seem that anything is going to happen upstream, so let's merge this with the patch. I have added a reference to the PR in the patch comment. If this is unmaintained, we should probably remove it at some point. clinfo is better anyway and maintained.

Result of nixpkgs-review pr 98054 1

1 package marked as broken and skipped:
  • ethminer
2 packages built:
  • ethash
  • opencl-info

Thanks @demyanrogozhin for fixing this derivation!

@danieldk danieldk merged commit 7a0672d into NixOS:master Sep 30, 2020
danieldk added a commit to danieldk/nixpkgs that referenced this pull request Sep 30, 2020
@danieldk
ethash: remove buildInputs
142a041 
When reviewing NixOS#98054, I noticed that this package has a bunch of
buildInputs that are unused. There are no references to OpenCL, mesa,
boost, cryptopp, or openmpi in the source code. The package compiles
fine with these buildInputs removed.
@danieldk danieldk mentioned this pull request Sep 30, 2020
Merged
10 tasks
@p-h p-h mentioned this pull request Oct 14, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@danieldk danieldk danieldk approved these changes

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@demyanrogozhin @danieldk @risicle @jonringer