Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tensorflow: Fix compilation with numpy 1.19.x #98083

Merged
merged 1 commit into from Sep 21, 2020
Merged

tensorflow: Fix compilation with numpy 1.19.x #98083

merged 1 commit into from Sep 21, 2020

Conversation

avdv
Copy link
Member

@avdv avdv commented Sep 16, 2020 •
edited

Motivation for this change

Current version does not build.

ZHF: #97479

Context: https://hydra.nixos.org/build/126811197/nixlog/1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@avdv
tensorflow: Fix compilation with numpy 1.19.x
8f5bfd6 
Numpy introduced a breaking API change in version 1.19.x, see [1].

There is a simple fix [2] available in the master branch.

[1]: tensorflow/tensorflow#40688
[2]: tensorflow/tensorflow@75ea0b3
@ofborg ofborg bot requested a review from abbradar September 16, 2020 08:32
@avdv avdv mentioned this pull request Sep 17, 2020
Closed
10 tasks
@danieldk
Copy link
Contributor

@ofborg build python37Packages.tensorflow

@danieldk danieldk changed the title Fix tensorflow building against numpy 1.19.x tensorflow: Fix compilation with numpy 1.19.x Sep 20, 2020
danieldk
danieldk approved these changes Sep 20, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice to have this fixed!

Tested CUDA build, confirmed that training works.

@FRidh @jonringer any objections against merging this?

jonringer
jonringer approved these changes Sep 20, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

@danieldk danieldk merged commit a034f20 into NixOS:master Sep 21, 2020
@avdv avdv deleted the zhf-fix-tensorflow branch September 21, 2020 06:14
@avdv avdv mentioned this pull request Sep 21, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@avdv @danieldk @jonringer