Add XR support to video.rVFC #25555
Merged
Add XR support to video.rVFC #25555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 15, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2406522
branch
from
d84528d
to
c0a97fe
Compare
Currently, when we enter an immersive XRSession, window.rAF calls stops, which means we no longer deliver video.requestVideoFrameCallback calls. This CL adds video.rVFC support to immersive XRSessions. If we find an immersive XRSession, we schedule video.rVFC callbacks there instead of the ScriptedAnimationController (SAC). There can only be one immersive XRSession. If we don't find a session, but we find that the XRFrameProvider exists, we request to be notified when an immersive session start. This allows us to keep callbacks going if the callbacks were already scheduled in the SAC when starting an XRSession. Simmilarly, if the session ends when callbacks were pending in the XRSession, we reschedule ourselves in the SAC. Bug: 1107578 Change-Id: If0acf9445bb789bc848e0043908fc9b769cc5bdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406522 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#807653}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2406522
branch
from
c0a97fe
to
2ce2cd6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when we enter an immersive XRSession, window.rAF calls stops,
which means we no longer deliver video.requestVideoFrameCallback calls.
This CL adds video.rVFC support to immersive XRSessions. If we find an
immersive XRSession, we schedule video.rVFC callbacks there instead of
the ScriptedAnimationController (SAC).
There can only be one immersive XRSession. If we don't find a session,
but we find that the XRFrameProvider exists, we request to be notified
when an immersive session start. This allows us to keep callbacks going
if the callbacks were already scheduled in the SAC when starting an
XRSession. Simmilarly, if the session ends when callbacks were pending
in the XRSession, we reschedule ourselves in the SAC.
Bug: 1107578
Change-Id: If0acf9445bb789bc848e0043908fc9b769cc5bdd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406522
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807653}