Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wip] hotel: init at 0.8.7 #98049

Closed
wants to merge 2 commits into from
Closed

[wip] hotel: init at 0.8.7 #98049

wants to merge 2 commits into from

Conversation

etu
Copy link
Contributor

@etu etu commented Sep 15, 2020 •
edited

Motivation for this change

I need this util since my team has decided to use it. Can be useful for others as well.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@etu etu force-pushed the init-hotel branch 3 times, most recently from 7a48cb1 to 019846c Compare September 15, 2020 17:28
@etu etu changed the title hotel: init at 0.8.7 [wip] hotel: init at 0.8.7 Sep 15, 2020
@etu etu closed this Sep 17, 2020
@etu etu deleted the init-hotel branch January 19, 2021 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@etu