Revert "[webdriver] Close old windows at the end of each test as well… #25544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
added
infra
wptrunner
Hexcles
approved these changes
Sep 15, 2020
stephenmcgruer
added a commit
that referenced
this pull request
Sep 18, 2020
… as beginning" (#25567) This is a reland of #24879 (which was reverted in #25544). It updates the code to only close the windows if the user hasn't asked us to pause after a test has run. From the original PR: ---- Previously, we closed old windows at the start of each test. This was nice in terms of defensiveness (don't assume the last run left the world in a good state), but made it hard to find problematic tests that left dialogs open (since they wouldn't throw until the next test). Instead, this patch does both - close both at the start and end of a test. This should improve the blaming situation, whilst still being defensive. There are potential performance implications to this patch, however test runs are inconclusive. Full runs of Chrome and Safari show +- 2%, which is possibly within margin of error. Running locally, some directories showed a ~2% slowdown, whilst others had little or no difference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… as beginning (#24879)"
This reverts commit c35a4f0.
Unfortunately this broke the debugging flow of --pause-after-test; the
window is closed at the end of the test so the user can't see the
results or edit/refresh etc.