[mathml] Disable multicol for MathML layout #25545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 15, 2020
This CL disables multicol for MathML, since it has been causing issue and is not needed for math layout. This is consistent with flexbox, grid, table or custom layout for example. In particular, this fixes an assertion failure when multicol is used on MathML token elements. Bug: 6606, 1128267 Change-Id: I9bb365b7af25e11b994dfc8f2470b3fa4ea2adeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410131 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#807361}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2410131
branch
from
3c51480
to
5817184
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL disables multicol for MathML, since it has been causing issue
and is not needed for math layout. This is consistent with flexbox,
grid, table or custom layout for example. In particular, this fixes
an assertion failure when multicol is used on MathML token elements.
Bug: 6606, 1128267
Change-Id: I9bb365b7af25e11b994dfc8f2470b3fa4ea2adeb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410131
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Frédéric Wang <fwang@igalia.com>
Cr-Commit-Position: refs/heads/master@{#807361}