libjson-rpc-cpp: 0.7.0 -> 1.3.0, fix build #98072
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This required a patch to allow it to build with
libmicrohttpd
0.9.71, which could only be found on an unmerged PR, so I included the patch in-tree so that we had a stable source for this.Bit of an odd situation though, after having fixed this I realized the only package we have that use(d) this is marked
broken
, so I have little way of testing whether this actually works.The result looks about right, though.I've just realized thejsonrpcstub
binary segfaults. I'm putting this on backburner as there are many other issue to take care of for 20.09, but posting it as a draft PR in case anyone interested wants to pick this up.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)