Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libjson-rpc-cpp: 0.7.0 -> 1.3.0, fix build #98072

Closed
wants to merge 1 commit into from

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Sep 15, 2020

Motivation for this change

This required a patch to allow it to build with libmicrohttpd 0.9.71, which could only be found on an unmerged PR, so I included the patch in-tree so that we had a stable source for this.

Bit of an odd situation though, after having fixed this I realized the only package we have that use(d) this is marked broken, so I have little way of testing whether this actually works. The result looks about right, though. I've just realized the jsonrpcstub binary segfaults. I'm putting this on backburner as there are many other issue to take care of for 20.09, but posting it as a draft PR in case anyone interested wants to pick this up.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

include patch in-tree as its origin, an unmerged github PR, is not
necessarily stable
@RaghavSood
Copy link
Member

This could also be updated to use libmicrohttpd_0_9_70 once #105242 is merged - 0.9.71 made a breaking change to the interface, and it seems to have broken a number of things

@stale
Copy link

stale bot commented Jul 20, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 20, 2021
@siraben siraben closed this Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: merge conflict 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants