Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing plan for :dir() pseudo-class #25569

Open
18 of 26 tasks
zcorpan opened this issue Sep 16, 2020 · 7 comments
Open
18 of 26 tasks

Testing plan for :dir() pseudo-class #25569

zcorpan opened this issue Sep 16, 2020 · 7 comments
Labels
selectors type:missing-coverage

Comments

@zcorpan
Copy link
Member

zcorpan commented Sep 16, 2020 •
edited by annevk

Relevant spec sections:

https://drafts.csswg.org/selectors-4/#the-dir-pseudo
https://html.spec.whatwg.org/multipage/semantics-other.html#selector-ltr

The interesting cases to test are from the definition of "directionality" in HTML:
https://html.spec.whatwg.org/multipage/dom.html#the-directionality

  • element with dir="ltr" matches :dir(ltr) [selectors4] Implement :dir pseudo-class #26159
  • root element without dir attribute matches :dir(ltr)
  • root element with dir="invalid" matches :dir(ltr)
  • <input type=tel> (HTML: Add test for <input type=tel> matching :dir() #25599)
    • without dir matches :dir(ltr)
    • with dir="invalid" matches :dir(ltr)
    • with dir="rtl" matches :dir(rtl)
  • element with dir="rtl" matches :dir(rtl)
  • child of element with dir="rtl" matches :dir(rtl)
  • <input type=text/search/tel/url/email dir=auto>
  • <textarea dir=auto>
  • element with dir=auto
    • first character is of bidirectional character type AL or R matches :dir(rtl)
    • first character is of bidirectional character type L matches :dir(ltr)
    • test the first strong bidi character being in a child bdi, script, style, textarea, element with dir=ltr/rtl/auto (should be ignored for auto logic)
    • test the first strong bidi character being in a child that is display: none (should still affect directionality) Fix the updating dir=auto issue when inserting text into a display:none #27125
    • element is the root element and text has no strong bidi characters, matches :dir(ltr)
    • text has no strong bidi characters, parent has dir=rtl, matches :dir(rtl)
  • <bdi> without dir with the same cases as "element with dir=auto"
  • <bdi dir=ltr> and first character is of bidirectional character type AL or R matches :dir(ltr)
  • <bdi dir=rtl> and first character is of bidirectional character type L matches :dir(rtl)
  • child of element with dir="ltr" matches :dir(ltr)
  • child of element with dir="rtl" matches :dir(rtl)
  • non-HTML element with an (invalid) dir attribute does not affect :dir() matching.
  • Shadow DOM Tests for directionality and shadow DOM #29820
  • <slot> Fix the wrong directionality of slots #27954

Check for existing coverage in wpt: git grep -l ":dir(" (in 16 Sep 2020)

css/css-scoping/shadow-directionality-001.tentative.html
css/css-scoping/shadow-directionality-002.tentative.html
css/selectors/selectors-dir-selector-ltr-001.html
css/selectors/selectors-dir-selector-rtl-001.html
css/vendor-imports/mozilla/mozilla-central-reftests/counter-styles-3/disclosure-styles-ref.html
css/vendor-imports/mozilla/mozilla-central-reftests/selectors4/dir-style-01a.html
css/vendor-imports/mozilla/mozilla-central-reftests/selectors4/dir-style-01b.html
css/vendor-imports/mozilla/mozilla-central-reftests/selectors4/dir-style-02a.html
css/vendor-imports/mozilla/mozilla-central-reftests/selectors4/dir-style-02b.html
css/vendor-imports/mozilla/mozilla-central-reftests/selectors4/dir-style-03a.html
css/vendor-imports/mozilla/mozilla-central-reftests/selectors4/dir-style-03b.html
css/vendor-imports/mozilla/mozilla-central-reftests/selectors4/dir-style-04.html
html/semantics/selectors/pseudo-classes/dir.html
html/semantics/selectors/pseudo-classes/dir01.html
shadow-dom/directionality-002.tentative.html

(Maybe also check for dir="auto" tests)
@zcorpan
Copy link
Member Author

zcorpan commented Sep 16, 2020

The html/semantics/selectors/pseudo-classes/dir.html test seems suitable to extend with additional cases.

zcorpan added a commit that referenced this issue Sep 17, 2020
@zcorpan
HTML: Add test for <input type=tel> matching :dir()
432ae5a 
Part of testing plan #25569
@zcorpan zcorpan mentioned this issue Sep 17, 2020
Merged
zcorpan added a commit that referenced this issue Sep 22, 2020
@zcorpan
HTML: Add test for <input type=tel> matching :dir()
aaf496b 
Part of testing plan #25569
@MyidShin
Copy link
Contributor

FYI, recently TCs[1][2] for :dir() which cover the list below have been added.

 element with dir="ltr" matches :dir(ltr)
 element with dir="rtl" matches :dir(rtl)
 child of element with dir="rtl" matches :dir(rtl)
 element with dir=auto ** not for <bdi> ** 
   first character is of bidirectional character type AL or R matches :dir(rtl)
   first character is of bidirectional character type L matches 
   test the first strong bidi character being in a child that is display: none (should still affect directionality)
   text has no strong bidi characters, parent has dir=rtl, matches :dir(rtl)
 child of element with dir="ltr" matches :dir(ltr)
 child of element with dir="rtl" matches :dir(rtl)
 non-HTML element with an (invalid) dir attribute does not affect :dir() matching.

I think it would be nice if the checklist includes something about shadow dom and [3]. :)

[1] 7741972
[2] 60d6e8d
[3] 126ec5c

@zcorpan
Copy link
Member Author

zcorpan commented Mar 30, 2021

Thanks @MyidShin! I've invited you to the web-platform-tests reviewers team, which I think would let you edit my comment. I'll edit my comment for now with your suggestions

@zcorpan zcorpan mentioned this issue Nov 10, 2022
Closed
@zcorpan
Copy link
Member Author

zcorpan commented Mar 23, 2023

cc @bkardell

@bkardell
Copy link
Contributor

It's interesting, I guess we need to compare because it looks like #29820 has like 40+ tests which I believe are just a couple of checkboxes here?

@past past mentioned this issue Mar 23, 2023
Closed
@dbaron dbaron mentioned this issue Aug 24, 2023
Merged
4 tasks
@dbaron
Copy link
Member

dbaron commented Aug 24, 2023

#41620 also has some tests to land for this.

@dbaron dbaron mentioned this issue Sep 26, 2023
Merged
4 tasks
annevk added a commit that referenced this issue Oct 9, 2023
@annevk
HTML: make dir=auto and dirname apply to more form controls
a3fc53c 
For whatwg/html#9689.

Helps with #25569 as this area was barely tested.

(Also correct some typos while here.)
@annevk annevk mentioned this issue Oct 9, 2023
Merged
annevk added a commit that referenced this issue Oct 24, 2023
@annevk
HTML: make dir=auto and dirname apply to more form controls
364c325 
For whatwg/html#9689.

Helps with #25569 as this area was barely tested.

(Also correct some typos while here.)
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Nov 7, 2023
@annevk @moz-wptsync-bot
Bug 1857951 [wpt PR 42427] - HTML: make dir=auto and dirname apply to…
931ef29 
… more form controls, a=testonly

Automatic update from web-platform-tests
HTML: make dir=auto and dirname apply to more form controls

For whatwg/html#9689.

Helps with web-platform-tests/wpt#25569 as this area was barely tested.

(Also correct some typos while here.)
--

wpt-commits: 364c325f6589ec43c8e0abd85dc3220c6592721d
wpt-pr: 42427
vinnydiehl pushed a commit to vinnydiehl/mozilla-unified that referenced this issue Nov 7, 2023
@annevk @moz-wptsync-bot
Bug 1857951 [wpt PR 42427] - HTML: make dir=auto and dirname apply to…
02e8ed9 
… more form controls, a=testonly

Automatic update from web-platform-tests
HTML: make dir=auto and dirname apply to more form controls

For whatwg/html#9689.

Helps with web-platform-tests/wpt#25569 as this area was barely tested.

(Also correct some typos while here.)
--

wpt-commits: 364c325f6589ec43c8e0abd85dc3220c6592721d
wpt-pr: 42427
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Nov 8, 2023
@marco-c
Bug 1857951 [wpt PR 42427] - HTML: make dir=auto and dirname apply to…
1217297 
… more form controls, a=testonly

Automatic update from web-platform-tests
HTML: make dir=auto and dirname apply to more form controls

For whatwg/html#9689.

Helps with web-platform-tests/wpt#25569 as this area was barely tested.

(Also correct some typos while here.)
--

wpt-commits: 364c325f6589ec43c8e0abd85dc3220c6592721d
wpt-pr: 42427

UltraBlame original commit: baa84c2ff0cb5d7c031e93e92f5694397affc2f5
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Nov 8, 2023
@marco-c
Bug 1857951 [wpt PR 42427] - HTML: make dir=auto and dirname apply to…
f6c8717 
… more form controls, a=testonly

Automatic update from web-platform-tests
HTML: make dir=auto and dirname apply to more form controls

For whatwg/html#9689.

Helps with web-platform-tests/wpt#25569 as this area was barely tested.

(Also correct some typos while here.)
--

wpt-commits: 364c325f6589ec43c8e0abd85dc3220c6592721d
wpt-pr: 42427

UltraBlame original commit: baa84c2ff0cb5d7c031e93e92f5694397affc2f5
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Nov 8, 2023
@marco-c
Bug 1857951 [wpt PR 42427] - HTML: make dir=auto and dirname apply to…
7a0450d 
… more form controls, a=testonly

Automatic update from web-platform-tests
HTML: make dir=auto and dirname apply to more form controls

For whatwg/html#9689.

Helps with web-platform-tests/wpt#25569 as this area was barely tested.

(Also correct some typos while here.)
--

wpt-commits: 364c325f6589ec43c8e0abd85dc3220c6592721d
wpt-pr: 42427

UltraBlame original commit: baa84c2ff0cb5d7c031e93e92f5694397affc2f5
@dbaron
Copy link
Member

dbaron commented Dec 13, 2023

Many additional tests have landed for this, but at some point one of us should go through the list in the initial comment and see what's missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
selectors type:missing-coverage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@zcorpan @dbaron @bkardell @MyidShin