Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] python3Packages.graphite_beacon: fix deps, add nixos test #98061

Merged
merged 1 commit into from Sep 15, 2020
Merged

[20.09] python3Packages.graphite_beacon: fix deps, add nixos test #98061

merged 1 commit into from Sep 15, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Sep 15, 2020 •
edited

Motivation for this change

backport #98055

ZHF #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
https://github.com/NixOS/nixpkgs/pull/98061
3 packages built:
python27Packages.graphite_beacon python37Packages.graphite_beacon python38Packages.graphite_beacon

@jonringer jonringer merged commit 797c5a8 into NixOS:release-20.09 Sep 15, 2020
@jonringer jonringer deleted the backport-graphite branch September 15, 2020 18:10
@jonringer jonringer changed the title python3Packages.graphite_beacon: fix deps, add nixos test [20.09] python3Packages.graphite_beacon: fix deps, add nixos test Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jonringer