Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.ihatemoney: disable sandbox unfriendly tests #98060

Merged
merged 1 commit into from Sep 16, 2020
Merged

python3Packages.ihatemoney: disable sandbox unfriendly tests #98060

merged 1 commit into from Sep 16, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Sep 15, 2020 •
edited

Motivation for this change

also fixed the passthru.tests, as nix-build won't normally recurse into a nested set, so nix-build -A python3Packages.ihatemoney.passthru.tests would actually build nothing.

ZHF #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
https://github.com/NixOS/nixpkgs/pull/98060
2 packages built:
python37Packages.ihatemoney python38Packages.ihatemoney

@ofborg ofborg bot requested a review from symphorien September 15, 2020 19:03
drewrisinger
drewrisinger approved these changes Sep 15, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Diff LGTM
  • Commits LGTM
  • Builds
https://github.com/NixOS/nixpkgs/pull/98060
2 packages built:
python37Packages.ihatemoney python38Packages.ihatemoney

symphorien
symphorien requested changes Sep 15, 2020
View reviewed changes
Copy link
Member

@symphorien symphorien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests used to pass in the sandbox so I suspect this is a regression. currently bissecting.

@symphorien
Copy link
Member

The regression is due to a7b5b18 python: dnspython: 1.16.0 -> 2.0.0

@symphorien
Copy link
Member

I guess disabling the tests is fine, because I can't figure out what broke or even if it should work at all.

@risicle
Copy link
Contributor

risicle commented Sep 16, 2020 •
edited

WFM linux x86_64

@risicle risicle merged commit b4338fb into NixOS:master Sep 16, 2020
@jonringer
Copy link
Contributor Author

@symphorien yea, that's fair. These failures might be indicative of an actual failure.

I guess it's just the tests are viewing the errors as "clients" and all that gets dumped is "unable to reach service" which isn't helpful.

@jonringer jonringer deleted the fix-ihatemoney branch September 20, 2020 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@symphorien symphorien symphorien requested changes

@drewrisinger drewrisinger drewrisinger approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jonringer @symphorien @risicle @drewrisinger