Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pforth: fix build with patch #98074

Merged
merged 1 commit into from Sep 20, 2020
Merged

pforth: fix build with patch #98074

merged 1 commit into from Sep 20, 2020

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Sep 15, 2020

Motivation for this change

ZHF: #97479

Patch from upstream fixes build with gnumake >= 4.3

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle
pforth: fix build with patch
7621c8b 
patch from upstream fixes build with gnumake>=4.3
@ofborg ofborg bot requested a review from yrashk September 15, 2020 22:08
@tomberek
Copy link
Contributor

Result of nixpkgs-review pr 98074 1

1 package built:
- pforth

@risicle risicle merged commit dc41390 into NixOS:master Sep 20, 2020
@risicle risicle mentioned this pull request Sep 20, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomberek tomberek tomberek approved these changes

@yrashk yrashk Awaiting requested review from yrashk

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@risicle @tomberek