Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update interfaces/encoding.idl and test #25542

Merged
merged 1 commit into from Sep 15, 2020
Merged

Update interfaces/encoding.idl and test #25542

merged 1 commit into from Sep 15, 2020

Conversation

stephenmcgruer
Copy link
Contributor

Closes #25537

annevk
annevk approved these changes Sep 15, 2020
View reviewed changes
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right, thanks!

cc @domenic

@stephenmcgruer stephenmcgruer merged commit d7f9e16 into master Sep 15, 2020
@stephenmcgruer stephenmcgruer deleted the smcgruer/encoding-idl branch September 15, 2020 15:39
@watilde watilde mentioned this pull request Sep 24, 2020
Closed
3 tasks
watilde added a commit to watilde/node that referenced this pull request Sep 28, 2020
@watilde
test: update wpt tests for encoding
0636458 
Refs: web-platform-tests/wpt#25542
watilde added a commit to nodejs/node that referenced this pull request Sep 28, 2020
@watilde
test: update wpt tests for encoding
6fc3b0d 
Refs: web-platform-tests/wpt#25542

PR-URL: #35330
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
watilde added a commit to watilde/node that referenced this pull request Sep 30, 2020
@watilde
test: update wpt tests for encoding
a00ecd6 
Refs: web-platform-tests/wpt#25542

PR-URL: nodejs#35330
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@watilde watilde mentioned this pull request Sep 30, 2020
Closed
4 tasks
danielleadams pushed a commit to nodejs/node that referenced this pull request Oct 6, 2020
@watilde @danielleadams
test: update wpt tests for encoding
552ebaf 
Refs: web-platform-tests/wpt#25542

PR-URL: #35330
Backport-PR-URL: #35422
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@watilde @joesepi
test: update wpt tests for encoding
5dc6b76 
Refs: web-platform-tests/wpt#25542

PR-URL: nodejs#35330
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk approved these changes

@foolip foolip Awaiting requested review from foolip

@inexorabletash inexorabletash Awaiting requested review from inexorabletash

Assignees

@foolip foolip

Labels
encoding interfaces
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@stephenmcgruer @annevk @foolip @wpt-pr-bot