Reland "[webdriver] Close old windows at the end of each test as well as beginning" #25567
Conversation
wpt-pr-bot
added
infra
wptrunner
|
@jgraham @gsnedders - PTAL. I'm not confident in re-using I'm also not confident in my methodology for deciding when we can and can't close windows, there's quite likely something I've missed :D |
|
Capturing IRC comments so I don't lose them.
jgraham also suggested just getting rid of close_after_done since it was never really utilized, but I'd like to do that cleanup separately from this change. |
|
@jgraham @gsnedders - I've switched to |
This is a reland of #24879 (which was reverted in #25544). It updates the code
to only close the windows if the user hasn't asked us to pause after a test has run.
From the original PR:
Previously, we closed old windows at the start of each test. This was nice in terms
of defensiveness (don't assume the last run left the world in a good state), but made
it hard to find problematic tests that left dialogs open (since they wouldn't throw until
the next test).
Instead, this patch does both - close both at the start and end of a test. This should
improve the blaming situation, whilst still being defensive.
There are potential performance implications to this patch, however test runs are
inconclusive. Full runs of Chrome and Safari show +- 2%, which is possibly within
margin of error. Running locally, some directories showed a ~2% slowdown, whilst
others had little or no difference.