Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x265: 3.2 -> 3.4 #98091

Merged
merged 1 commit into from Oct 6, 2020
Merged

x265: 3.2 -> 3.4 #98091

merged 1 commit into from Oct 6, 2020

Conversation

titouanco
Copy link
Contributor

  • Change version from 3.2 to 3.4
  • Use fetchFromBitbucket to fetch the archive from multicoreware/x265_git instead of the videolan server (doesn't have the latest version)
  • Remove the ARM patch, doesn't work anymore but doesn't seems necessary since this commit
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from codyopel September 16, 2020 10:57
@ajs124 ajs124 mentioned this pull request Sep 16, 2020
Closed
10 tasks
@FRidh FRidh changed the base branch from master to staging October 6, 2020 08:17
@FRidh FRidh merged commit c1a0aa7 into NixOS:staging Oct 6, 2020
@thefloweringash thefloweringash mentioned this pull request Oct 17, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codyopel codyopel Awaiting requested review from codyopel

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@titouanco @FRidh @Janik-Haag