/marvin opt-in
/status needs_reviewer

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

What does this do that

mkShell {
  buildInputs = [
    (agda.withPackages (p: [ ... ])
  ];
}

doesn't?

It doesn't build the package itself, but only its dependencies. See updated docs.

Ah right I understand. Perhaps we should follow what haskell does and have this under packageName.passthru.env

Aha. I hadn't even heard of passthru.env until now. It seems undocumented. There is a shellFor as well for Haskell, though. Not sure which one is more general, but I believe shellFor. It at least has a test, it seems.

In Haskell's shellFor it's possible to add a list of packages, in fact, and also further dev tools like editors, linters etc., maybe we want that here as well?

We could actually have both, a shellFor and an env which calls shellFor. What do you think?

I think having the env attribute is nice, as then you can just put library.env in your shell

@alexarice Like this?

This doesn't work, it seems.

Does that actually work, I'd have thought you need some sort of mkShell command (as you did for the original shellFor). I thought the plan was to keep both

I thought the plan was to keep both

Ah ok, I misunderstood you then 😅 Ok I'll bring back both.

I was thinking of the sort of thing in pkgs/development/haskell-modules/generic-builder.nix

Ok, I should be able to make something from that, thanks!

Reminder: Please review!

This Pull Request is awaiting review. If you are the assigned reviewer, please have a look. Try to find another reviewer if necessary. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR will be should be put back in the needs_reviewer queue in one day.

Note: This feature is currently broken. The bot will not actually change the status. If you see this message multiple times, please request a status change manually.

Reminder: Please review!

This Pull Request is awaiting review. If you are the assigned reviewer, please have a look. Try to find another reviewer if necessary. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR will be should be put back in the needs_reviewer queue in one day.

Note: This feature is currently broken. The bot will not actually change the status. If you see this message multiple times, please request a status change manually.

Sorry for the bot spam (see timokau/marvin-mk2#90 and #121518 (comment)).

/status awaiting_changes

Hi!

The marvin-mk2 bot is now discontinued. I have removed the relevant tags from this PR. If you still need someone to look at it, one option would be to ask in this discourse thread.

I am posting this notice to all open PRs with the marvin tag. Please understand that following all of these discussions would take too much time, so I will unsubscribe from this PR unless I have already been involved in it before this message.