Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump VSCode version #98088

Merged
merged 2 commits into from Oct 16, 2020
Merged

Bump VSCode version #98088

merged 2 commits into from Oct 16, 2020

Conversation

turion
Copy link
Contributor

@turion turion commented Sep 16, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@turion
Copy link
Contributor Author

turion commented Sep 16, 2020

Unfortunately this is blocked on VSCodium/vscodium#500

@austinbutler austinbutler mentioned this pull request Sep 21, 2020
Closed
10 tasks
@srid
Copy link
Contributor

srid commented Oct 8, 2020

Should be closed? 1.50 is out.

@turion
Copy link
Contributor Author

turion commented Oct 9, 2020

@srid Oh good point. I'll pump to 1.50 right away. (Or do you want a separate PR for that?)

@turion turion mentioned this pull request Oct 9, 2020
Closed
@turion
Copy link
Contributor Author

turion commented Oct 9, 2020

Unfortunately blocked on VSCodium/vscodium#529. The update.sh doesn't run through.

@turion turion force-pushed the vscode_1.49.0 branch 2 times, most recently from 2fc70f2 to e8c45fa Compare October 12, 2020 12:42
@turion
Copy link
Contributor Author

turion commented Oct 12, 2020

@srid This is now fixed and rebased.

/marvin opt-in
/status needs_reviewer

@marvin-mk2 marvin-mk2 bot added the marvin label Oct 12, 2020
@marvin-mk2
Copy link

marvin-mk2 bot commented Oct 12, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@ofborg ofborg bot requested a review from Synthetica9 October 12, 2020 12:53
@marvin-mk2
Copy link

marvin-mk2 bot commented Oct 15, 2020

Reminder: Please review!

This Pull Request is awaiting review. If you are the assigned reviewer, please have a look. Try to find another reviewer if necessary. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR will be put back in the needs_reviewer queue in one day.

@turion
Copy link
Contributor Author

turion commented Oct 15, 2020

@srid can you review or merge?

@turion
Copy link
Contributor Author

turion commented Oct 15, 2020

Huh. upkeep-bot was faster. I wonder whether there is any point in doing this.

@turion
Copy link
Contributor Author

turion commented Oct 15, 2020

@eadwu @Synthetica are vscode/vscodium versions bumped automatically when the script works fine?

@ofborg ofborg bot requested a review from eadwu October 15, 2020 17:41
eadwu
eadwu approved these changes Oct 15, 2020
View reviewed changes
Copy link
Member

@eadwu eadwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure as I never used the update script, nor do I use the stable version.

Verified hashes.

@samuela
Copy link
Member

samuela commented Oct 16, 2020

@eadwu @Synthetica are vscode/vscodium versions bumped automatically when the script works fine?

Yup! You can see the trace of all previous runs of the bot here: https://github.com/samuela/nixpkgs-upkeep/actions. It creates PRs whenever the update scripts work. I've found that they only ever really break when vscode has a new release but the vscodium version is not yet released.

@turion
Copy link
Contributor Author

turion commented Oct 16, 2020

That's great to know. I've documented this now, so people won't waste their time so much in the future.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/248

@ofborg ofborg bot requested a review from eadwu October 16, 2020 07:40
danieldk
danieldk suggested changes Oct 16, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update the commit message for the version bump to follow the contribution guidelines?

vscode, vscodium: 1.50.0 -> 1.50.1

This may seem like nitpicking, but makes it easier to search or process the logs.

@danieldk
Copy link
Contributor

danieldk commented Oct 16, 2020 •
edited

Also, the second commit message should be something like:

vscode, vscodium: document update scripts

Feel free to ping me when these changes are made to get this merged.

@turion
Copy link
Contributor Author

turion commented Oct 16, 2020

@danieldk Done :)

danieldk
danieldk approved these changes Oct 16, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the commit messages. Looks good to me now.

Result of nixpkgs-review pr 98088 1

3 packages built:
  • vscode
  • vscode-with-extensions
  • vscodium

@danieldk danieldk merged commit 33d73ba into NixOS:master Oct 16, 2020
This was referenced Oct 16, 2020
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srid srid srid approved these changes

@danieldk danieldk danieldk approved these changes

@Synthetica9 Synthetica9 Awaiting requested review from Synthetica9

@eadwu eadwu Awaiting requested review from eadwu

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer awaiting_reviewer marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@turion @srid @samuela @nixos-discourse @danieldk @eadwu @ryantm