Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.hickle: disable tests #98064

Merged
merged 2 commits into from Sep 16, 2020
Merged

python3Packages.hickle: disable tests #98064

merged 2 commits into from Sep 16, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Sep 15, 2020 •
edited

Motivation for this change

noticed it was broken reviewing #97846

Incompatible with astropy>=4.0

ZHF: #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
https://github.com/NixOS/nixpkgs/pull/98064
4 packages built:
python37Packages.hickle python37Packages.pywick python38Packages.hickle python38Packages.pywick

@jonringer
python3Packages.hickle: disable tests
4d524b0 
Incompatible with astropy>=4.0
@jonringer
python2Packages.hickle: disable
66e70be 
```
  Processing ./hickle-4.0.1-py2-none-any.whl
  ERROR: Package 'hickle' requires a different Python: 2.7.18 not in '>=3.5'
```
drewrisinger
drewrisinger approved these changes Sep 15, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Diff LGTM
  • Commits LGTM, could be squashed, but doesn't matter.
  • Builds
https://github.com/NixOS/nixpkgs/pull/98064
4 packages built:
python37Packages.hickle python37Packages.pywick python38Packages.hickle python38Packages.pywick

@ofborg ofborg bot requested a review from bcdarwin September 15, 2020 19:28
@jonringer jonringer merged commit f1325cd into NixOS:master Sep 16, 2020
@jonringer jonringer deleted the fix-hickle branch September 16, 2020 07:27
@jonringer jonringer mentioned this pull request Sep 19, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewrisinger drewrisinger drewrisinger approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@bcdarwin bcdarwin Awaiting requested review from bcdarwin

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @drewrisinger