Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.lightparam: fix source and deps #98065

Merged
merged 1 commit into from Sep 19, 2020
Merged

python3Packages.lightparam: fix source and deps #98065

merged 1 commit into from Sep 19, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Sep 15, 2020 •
edited

Motivation for this change

noticed it was broken reviewing #97846

source was broken:

hash mismatch in fixed-output derivation '/nix/store/y7x8gnv9b3ydwag4p33n3hz6a3ypin2p-lightparam-0.4.6-py3-none-any.whl':
  wanted: sha256:0cf6962rig1pbghpprg27b78qscycnprpcbdl2vay222a8b319pc
  got:    sha256:0hxchr7gqs09xzblw4l9rr50vcqrr3iclgj4f3gpihf4mhp0nxkr

deps were also broken

ZHF: #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
https://github.com/NixOS/nixpkgs/pull/98065
4 packages built:
python37Packages.lightparam python37Packages.stytra python38Packages.lightparam python38Packages.stytra

drewrisinger
drewrisinger approved these changes Sep 15, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Diff LGTM
  • Commit LGTM
  • Builds
https://github.com/NixOS/nixpkgs/pull/98065
4 packages built:
python37Packages.lightparam python37Packages.stytra python38Packages.lightparam python38Packages.stytra

@tbenst
Copy link
Contributor

tbenst commented Sep 15, 2020

Thank you! LGTM

@risicle
Copy link
Contributor

risicle commented Sep 16, 2020 •
edited

nixpkgs-review is being annoying and not giving me full logs, let me try and get them... no sorry that's because it's the notebook dependency failing, not this, ignore me

@jonringer jonringer merged commit 2a35f66 into NixOS:master Sep 19, 2020
@jonringer jonringer deleted the fix-lightparam branch September 19, 2020 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewrisinger drewrisinger drewrisinger approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@tbenst tbenst Awaiting requested review from tbenst

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jonringer @tbenst @risicle @drewrisinger