Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slurm: 20.02.4.1 -> 20.02.5.1 #98066

Merged
merged 1 commit into from Sep 19, 2020
Merged

slurm: 20.02.4.1 -> 20.02.5.1 #98066

merged 1 commit into from Sep 19, 2020

Conversation

markuskowa
Copy link
Member

Motivation for this change

Bugfix update: https://github.com/SchedMD/slurm/blob/slurm-20.02/NEWS
Needs back port to 20.09

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from jagajaga September 15, 2020 20:07
lsix
lsix approved these changes Sep 16, 2020
View reviewed changes
Copy link
Member

@lsix lsix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built & tested (with nixos/tests/slurm.nix).

All good for me.

@ehmry ehmry merged commit 84d11cd into NixOS:master Sep 19, 2020
@markuskowa
Copy link
Member Author

Back ported to 20.09 in 969984b

@markuskowa markuskowa deleted the upd-slurm2 branch September 21, 2020 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehmry ehmry ehmry approved these changes

@lsix lsix lsix approved these changes

@jagajaga jagajaga Awaiting requested review from jagajaga

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@markuskowa @ehmry @lsix