Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

traefik: fix dashboard by using source releases #98092

Merged
merged 1 commit into from Sep 27, 2020
Merged

traefik: fix dashboard by using source releases #98092

merged 1 commit into from Sep 27, 2020

Conversation

bennofs
Copy link
Contributor

@bennofs bennofs commented Sep 16, 2020

The traefik dashboard depends on static files built with npm.
The source releases included the prebundled static files ,
so switching to them fixes the issue.

Motivation for this change

The inbuilt traefik dashboard does not work with the nix package (404 not found). This is because the static files in static/ of the source repo are not built by the package. We can fix this by using the source package with bundled javascripts from github.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bennofs
traefik: fix dashboard by using source releases
6c9dba6 
The traefik dashboard depends on static files built with npm.
The source releases included the prebundled static files ,
so switching to them fixes the issue.
@ofborg ofborg bot requested a review from kalbasit September 16, 2020 11:29
@amaxine
Copy link
Member

amaxine commented Sep 16, 2020

Result of nixpkgs-review pr 98092 1

1 package built:
  • traefik

amaxine
amaxine approved these changes Sep 16, 2020
View reviewed changes
Copy link
Member

@amaxine amaxine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to be working, the test passes.

Fixes #41378 btw :)

@bennofs bennofs merged commit f7e5bb0 into NixOS:master Sep 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amaxine amaxine amaxine approved these changes

@vdemeester vdemeester Awaiting requested review from vdemeester

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bennofs @amaxine