Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vcv-rack: fix broken pffft reference #98051

Merged
merged 1 commit into from Sep 18, 2020
Merged

vcv-rack: fix broken pffft reference #98051

merged 1 commit into from Sep 18, 2020

Conversation

lb5tr
Copy link
Contributor

@lb5tr lb5tr commented Sep 15, 2020 •
edited

Motivation for this change

VCV-Rack fails to install due to broken https://bitbucket.org/jpommier/pffft revision (revision does't exist anymore, results in 404 when trying to download from bitbucket):

$ nix-env -i VCV-Rack

...

trying https://bitbucket.org/jpommier/pffft/get/29e4f76ac53bef048938754f32231d7836401f79.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 404
error: cannot download source from any mirror
builder for '/nix/store/zvvly7vp99xs40a7qplvl6ch0v27ggg6-source.drv' failed with exit code 1
cannot build derivation '/nix/store/i5c7ciilfyrjf4s3zxmgjmgy3zikvafq-VCV-Rack-1.1.6.drv': 1 dependencies couldn't be built
error: build of '/nix/store/i5c7ciilfyrjf4s3zxmgjmgy3zikvafq-VCV-Rack-1.1.6.drv' failed
Things done

Updated the revision to current master head. Checksum of the tarball didn't change so this change should be safe to merge.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lb5tr lb5tr mentioned this pull request Sep 15, 2020
Closed
@lb5tr
Copy link
Contributor Author

lb5tr commented Sep 15, 2020

linked issue: #98003

@lb5tr lb5tr changed the title vcv-rack: fix broken pfft reference vcv-rack: fix broken pffft reference Sep 15, 2020
@Moredread Moredread closed this Sep 16, 2020
@Moredread Moredread reopened this Sep 16, 2020
@Moredread
Copy link
Contributor

This also should be applied/backported to 20.09. The package hash hasn't changed, so it only fixes the source location.

@ddellacosta
Copy link

What are the next steps for getting this merged in? Anything I can do to help?

Sorry that I'm ignorant of this process, would be happy to read more about it if someone wants to point me at the right docs.

@lb5tr
Copy link
Contributor Author

lb5tr commented Sep 18, 2020

I'll take care of backporting to 29.09 once this is merged.

Thanks!

@ajs124 ajs124 merged commit 5096b51 into NixOS:master Sep 18, 2020
lb5tr pushed a commit to lb5tr/nixpkgs that referenced this pull request Sep 18, 2020
@ajs124 @lb5tr
Merge pull request NixOS#98051 from lb5tr/master
f2a5a20 
vcv-rack: fix broken pffft reference
(cherry picked from commit 5096b51)

Reason: only changed download ref. Source code of pffft remains unchanged.
@lb5tr
Copy link
Contributor Author

lb5tr commented Sep 18, 2020

backport PR #98237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Moredread Moredread Moredread approved these changes

@Sohalt Sohalt Sohalt approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@lb5tr @Moredread @ddellacosta @Sohalt @ajs124 @Janik-Haag