New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check that there are some resource entries #25547
base: master
Are you sure you want to change the base?
Add check that there are some resource entries #25547
Conversation
Test resource_initiator_types doesn't check that any entries have returned from resrouce timing. The test currently doesn't return stable number of entries but we need to at least ensure there are some entries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good modulo moving the assert into a test
@@ -135,6 +135,8 @@ | |||
addEntryIfExists(entries, expected_entries, pathname + 'empty.py?favicon', 'link'); | |||
addEntryIfExists(entries, expected_entries, pathname + 'eventsource.py?id=eventsource', 'other'); | |||
|
|||
assert_greater_than(entries.length, 0, 'There should be resrouce entries.'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assert_greater_than(entries.length, 0, 'There should be resrouce entries.'); | |
assert_greater_than(entries.length, 0, 'There should be resource entries.'); |
Added performance observer to improve test reliability. Excluded eventSource type for simplicity
Since event source repeatedly triggers resource timing events we need to exclude it from the count and ensure at least one arrived.
It's possible the Firefox failure is a flakiness in the implementation itself and not about the test being flaky, so in some sense it's possible that we may want to fix the lints and then force-merge. But some investigation is required in any case. |
Test resource_initiator_types doesn't check that any entries have returned from resrouce timing.
The test currently doesn't return stable number of entries but we need to at least ensure there are some entries.