Revert "[mathml] Use post.underlineThickness for the default fraction rulethickness" #25551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… rulethickness" This reverts commit d01e107517ff5b1da0544be36c5caaf30c27456e. Reason for revert: <breaks win7 bots - https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29> Original change's description: > [mathml] Use post.underlineThickness for the default fraction rulethickness > > MathML Core currently defines fallback values to use when no MATH table > is available. This CL performs the remaining work to ensure fractions > align with the specification. It also adds WPT test to check these > fraction fallback parameters, although testing them extensively is > difficult. > > Bug: 6606, 1058369 > Change-Id: Ic916c0c4b925674d526d78989988e57d8735bf4e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410384 > Commit-Queue: Frédéric Wang <fwang@igalia.com> > Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#807083} TBR=ikilpatrick@chromium.org,fwang@igalia.com,rbuis@igalia.com Change-Id: Ia8857539d69bbbafda2be5501ac1b766488be77d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 6606 Bug: 1058369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412750 Reviewed-by: David Bienvenu <davidbienvenu@google.com> Commit-Queue: David Bienvenu <davidbienvenu@google.com> Cr-Commit-Position: refs/heads/master@{#807144}
wpt-pr-bot
approved these changes
Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit d01e107517ff5b1da0544be36c5caaf30c27456e.
Reason for revert: <breaks win7 bots - https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29>
Original change's description:
TBR=ikilpatrick@chromium.org,fwang@igalia.com,rbuis@igalia.com
Change-Id: Ia8857539d69bbbafda2be5501ac1b766488be77d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 6606
Bug: 1058369
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412750
Reviewed-by: David Bienvenu <davidbienvenu@google.com>
Commit-Queue: David Bienvenu <davidbienvenu@google.com>
Cr-Commit-Position: refs/heads/master@{#807144}