Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve content on the landing page #535

Merged
merged 1 commit into from Sep 16, 2020
Merged

improve content on the landing page #535

merged 1 commit into from Sep 16, 2020

Conversation

garbas
Copy link
Member

@garbas garbas commented Sep 16, 2020 •
edited

This PR fixes:

  • Why choose Nix or NixOS? title removed
  • In "why Nix" section we should hide those gray circles until they are designed (at the end)
  • remove "Install Nix” button from navbar
  • one more example added (eg. NixOS test)
  • replaced the lorem ipsum in other examples
  • fixed items in the footer

This change is Reviewable

@github-actions
Copy link
Contributor

🚀 Deployed on https://5f623026a2a4c5008977d15c--nixos-homepage.netlify.app

@davidak
Copy link
Member

davidak commented Sep 16, 2020

I think the "Why choose Nix or NixOS? title" is important to give context to the section.

Screenshot from 2020-09-16 17-54-29

It don't look that bad without the icons.

The rest is good.

@garbas
Copy link
Member Author

garbas commented Sep 16, 2020

I think the "Why choose Nix or NixOS? title" is important to give context to the section.

I think it is clear what this sections is for. Even currently we don't have a title.
Also the content of this 3 items will change once we come to that point.

@garbas garbas merged commit 3447772 into feature/2020-redesign Sep 16, 2020
@garbas garbas deleted the feature/2020-redesign-improve-landing-page-content branch September 16, 2020 17:08
@garbas garbas mentioned this pull request Sep 16, 2020
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samueldr samueldr Awaiting requested review from samueldr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@garbas @davidak