nixos/cassandra: Add cfg.extraEnvSh #98107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cransom could you have a look please? |
| @@ -38,13 +38,18 @@ let | |||
| cassandraYaml = builtins.toJSON cassandraConfigWithAddresses; | |||
| cassandraEnvPkg = "${cfg.package}/conf/cassandra-env.sh"; | |||
| cassandraLogbackConfig = pkgs.writeText "logback.xml" cfg.logbackConfig; | |||
| passAsFile = [ "extraEnvSh" ]; | |||
| inherit (cfg) extraEnvSh; | |||
There was a problem hiding this comment.
This is necessary for passAsFile? Or could you do passAsFile = [ "cfg.extraEnvSh" ];?
There was a problem hiding this comment.
Yes, those two lines pretty much sum up how it works.
It's documented in the Nix manual if you'd like to know more.
There was a problem hiding this comment.
Ahh, right! The second line is required to make it an environment variable in the first place.
Yes I have and it works. |
JohnAZoidberg
approved these changes
Oct 7, 2020
|
Thanks @JohnAZoidberg ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Allow extending
cassandra-env.sh, as is required when extending the classpath. This can be used for custom logging.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)