Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matrix-synapse: 1.19.1 -> 1.19.2 #98097

Merged
merged 1 commit into from Sep 16, 2020
Merged

matrix-synapse: 1.19.1 -> 1.19.2 #98097

merged 1 commit into from Sep 16, 2020

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Sep 16, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ajs124 ajs124 marked this pull request as ready for review September 16, 2020 13:53
@ajs124 ajs124 requested a review from Ma27 September 16, 2020 13:53
@ajs124 ajs124 added 1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. labels Sep 16, 2020
fadenb
fadenb approved these changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@fadenb fadenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

Ran 1142 tests in 511.921s

PASSED (skips=5, successes=1137)

@mweinelt
Copy link
Member

mweinelt commented Sep 16, 2020 •
edited 

Ran 1142 tests in 633.275s

PASSED (skips=5, successes=1137)

/nix/store/njykssngnvk9w4zilwp4n0711k4a9415-vm-test-run-matrix-synapse

LGTM

martinetd
martinetd approved these changes Sep 16, 2020
View reviewed changes
Copy link
Member

@martinetd martinetd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cherry-picked on 20.03 works-for-me (build tests as quoted previously and actual functionality seems OK)

@tokudan tokudan mentioned this pull request Sep 16, 2020
Merged
10 tasks
@mguentner
Copy link
Contributor

cherry-picked on 20.03 works-for-me (build tests as quoted previously and actual functionality seems OK)

Can confirm

@tokudan tokudan mentioned this pull request Sep 16, 2020
Merged
10 tasks
@ajs124 ajs124 merged commit 233ae7b into NixOS:master Sep 16, 2020
@ajs124 ajs124 deleted the upd/matrix-synapse branch September 16, 2020 21:06
@Ma27
Copy link
Member

Ma27 commented Sep 17, 2020

@ajs124 thanks a lot for taking care of this! ❤️

@TredwellGit TredwellGit added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@fadenb fadenb fadenb approved these changes

@dali99 dali99 dali99 approved these changes

@martinetd martinetd martinetd approved these changes

@Ma27 Ma27 Awaiting requested review from Ma27

@pacien pacien Awaiting requested review from pacien

@Ekleog Ekleog Awaiting requested review from Ekleog

@Ralith Ralith Awaiting requested review from Ralith

@mguentner mguentner Awaiting requested review from mguentner

Assignees
No one assigned
Labels
1.severity: security 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@ajs124 @mweinelt @mguentner @Ma27 @fadenb @dali99 @martinetd @TredwellGit