Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elixir_1_11: init at 1.11.0 #99883

Merged
merged 2 commits into from Oct 19, 2020
Merged

elixir_1_11: init at 1.11.0 #99883

merged 2 commits into from Oct 19, 2020

Conversation

mtanzi
Copy link
Contributor

@mtanzi mtanzi commented Oct 6, 2020

Motivation for this change

Set elixir_1_11 as default elixir version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cw789
Copy link
Contributor

cw789 commented Oct 7, 2020

Hi @mtanzi. Cool thanks.

In 1.11.nix minimumOTPVersion could still be "21".
→ https://hexdocs.pm/elixir/compatibility-and-deprecations.html#compatibility-between-elixir-and-erlang-otp

@mtanzi
Copy link
Contributor Author

mtanzi commented Oct 7, 2020 •
edited

In 1.11.nix minimumOTPVersion could still be "21".
→ https://hexdocs.pm/elixir/compatibility-and-deprecations.html#compatibility-between-elixir-and-erlang-otp

Thanks @cw789, well spotted! I will fix that 👍

@mtanzi
elixir_1_11: init at 1.11.0
26857cc 
Set elixir_1_11 as default elixir version.
@cw789
Copy link
Contributor

cw789 commented Oct 7, 2020

Tested via nixpkgs-review pr 99883.

2 packages built:
elixir elixir_1_10

Execution of elixir --version is fine.

Erlang/OTP 22 [erts-10.7] [source] [64-bit] [smp:8:8] [ds:8:8:10] [async-threads:1] [hipe]

Elixir 1.11.0 (compiled with Erlang/OTP 22)

@fritzblue
Copy link

@mtanzi @cw789 Where did this land? 😄

@mtanzi
Copy link
Contributor Author

mtanzi commented Oct 12, 2020

@fritzblue I am hoping someone is going to merge it soon 😅 🤞

@cw789
Copy link
Contributor

cw789 commented Oct 14, 2020

Hey @Havvy @couchemar @ankhers @filalex77.
Is anyone available for review to speedup getting this PR merged?

ankhers
ankhers approved these changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@ankhers ankhers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@afontaine
Copy link
Contributor

Result of nixpkgs-review pr 99883 1

1 package built:
  • elixir (elixir_1_11)

@ajs124
Copy link
Member

ajs124 commented Oct 18, 2020

@r-ryantm just openend #99883, which is probably a duplicate of this. Although it upgrades to 1.11.1 instead of 1.11.0, so that might be something you might also want to do here.

@mtanzi
Copy link
Contributor Author

mtanzi commented Oct 18, 2020

@ajs124 I've updated the PR with the latest elixir (v1.11.1) 👍

@cw789
Copy link
Contributor

cw789 commented Oct 19, 2020

nixpkgs-review pr 99883 → build elixir (elixir_1_11) ✔

Erlang/OTP 22 [erts-10.7] [source] [64-bit] [smp:8:8] [ds:8:8:10] [async-threads:1] [hipe]

Elixir 1.11.1 (compiled with Erlang/OTP 22)

@cw789 cw789 mentioned this pull request Oct 19, 2020
Closed
@ryantm ryantm merged commit 1264223 into NixOS:master Oct 19, 2020
@mtanzi mtanzi deleted the elixir-1.11.0 branch October 19, 2020 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankhers ankhers ankhers approved these changes

Assignees
No one assigned
Labels
6.topic: erlang 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@mtanzi @cw789 @fritzblue @afontaine @ajs124 @ankhers @ryantm @Janik-Haag