Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

embree: 3.11.0 -> 3.12.0 #99728

Merged
merged 1 commit into from Oct 6, 2020
Merged

embree: 3.11.0 -> 3.12.0 #99728

merged 1 commit into from Oct 6, 2020

Conversation

siraben
Copy link
Member

@siraben siraben commented Oct 6, 2020

Motivation for this change

Addresses #99049

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from Hodapp87 and gebner October 6, 2020 14:23
@ofborg ofborg bot requested a review from gebner October 6, 2020 15:13
@siraben
embree: 3.11.0 -> 3.12.0
436be88 
And fix build on darwin.
@ofborg ofborg bot requested a review from gebner October 6, 2020 17:40
@gebner gebner merged commit 83eeedd into NixOS:master Oct 6, 2020
@siraben siraben deleted the embree-darwin branch October 6, 2020 17:41
@gebner gebner mentioned this pull request Oct 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hodapp87 Hodapp87 Awaiting requested review from Hodapp87

@gebner gebner Awaiting requested review from gebner

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@siraben @gebner