Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.09] python3Packages.localzone: 0.9.6 -> 0.9.7 #99889

Merged
merged 2 commits into from Oct 6, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 6, 2020

Motivation for this change

(cherry picked from commit 0093e4e)

backport #99571
backport #99886

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer requested a review from FRidh as a code owner October 6, 2020 18:59
@jonringer
Copy link
Contributor Author

also had to backport #99571 as ape was failing

https://github.com/NixOS/nixpkgs/pull/99889
1 package failed to build:
ape

4 packages built:
lexicon python27Packages.localzone python37Packages.localzone python38Packages.localzone

@jonringer
Copy link
Contributor Author

https://github.com/NixOS/nixpkgs/pull/99889
5 packages built:
ape lexicon python27Packages.localzone python37Packages.localzone python38Packages.localzone

@jonringer jonringer merged commit 695d9d3 into NixOS:release-20.09 Oct 6, 2020
@jonringer jonringer deleted the backport-localzone branch October 16, 2020 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant