Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow arguments other than Time in FFT #2752

Merged
merged 3 commits into from
Oct 7, 2020

Conversation

eggrobin
Copy link
Member

@eggrobin eggrobin commented Oct 6, 2020

This will be used in Clenshaw-Curtis, which in turn will be used to compute the inner products and norms in the Modified Gram-Schmidt introduced by #2750, continuing the inexorable progress towards #2400.

numerics/fast_fourier_transform.hpp Show resolved Hide resolved
private:
Time const Δt_;
Difference<Argument> const Δt_;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Document that this is only a bona fide time if Argument is time-like.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what the type says (and the word time does not appear anyway).

numerics/fast_fourier_transform_body.hpp Outdated Show resolved Hide resolved
numerics/fast_fourier_transform_body.hpp Outdated Show resolved Hide resolved
numerics/fast_fourier_transform_body.hpp Show resolved Hide resolved
numerics/fast_fourier_transform.hpp Show resolved Hide resolved
std::array<Voltage, n> u{{1 * Volt, 0 * Volt, 1 * Volt, 0 * Volt}};
FastFourierTransform<Voltage, Instant, n> const U(u, Δt);

FastFourierTransform<Voltage, AngularFrequency, n> const nu(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use Greek nu?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is n times u. Renamed u to v for clarity.

numerics/fast_fourier_transform_test.cpp Outdated Show resolved Hide resolved
@pleroy pleroy added the LGTM label Oct 7, 2020
@pleroy
Copy link
Member

pleroy commented Oct 7, 2020

retest this please

@eggrobin eggrobin merged commit a127da7 into mockingbirdnest:master Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants