Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnomeExtensions.freon: init at 40 #99892

Merged
merged 2 commits into from Oct 11, 2020
Merged

gnomeExtensions.freon: init at 40 #99892

merged 2 commits into from Oct 11, 2020

Conversation

justinas
Copy link
Contributor

@justinas justinas commented Oct 6, 2020 •
edited

Motivation for this change

freon is a more up-to-date fork of the Sensors gnome extension. It lets one monitor temperatures provided via lm_sensors as well as through nvidia-smi and bumblebee.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Oct 6, 2020
@justinas justinas force-pushed the gnome-shell-freon branch 2 times, most recently from d69b5b4 to 639bfe7 Compare October 9, 2020 20:44
bjornfor
bjornfor approved these changes Oct 11, 2020
View reviewed changes
Copy link
Contributor

@bjornfor bjornfor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: please add your maintainers entry in a separate commit (no need for separate PR, just split existing commit in two and put maintainers commit first).

@justinas
Copy link
Contributor Author

Nit: please add your maintainers entry in a separate commit (no need for separate PR, just split existing commit in two and put maintainers commit first).

Thanks for reviewing @bjornfor ! I have split the commit into two.

@bjornfor bjornfor merged commit 6bdbd6b into NixOS:master Oct 11, 2020
@bjornfor
Copy link
Contributor

@justinas: Thanks!

@justinas justinas deleted the gnome-shell-freon branch October 11, 2020 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor approved these changes

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@justinas @bjornfor