Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ogre: 1.12.1 -> 1.12.9, cegui: enable build on darwin #99727

Closed
wants to merge 3 commits into from
Closed

ogre: 1.12.1 -> 1.12.9, cegui: enable build on darwin #99727

wants to merge 3 commits into from

Conversation

siraben
Copy link
Member

@siraben siraben commented Oct 6, 2020 •
edited

Description of changes

Update and fix darwin build.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@siraben siraben force-pushed the ogre-darwin branch 2 times, most recently from cf0f1f0 to 37ca792 Compare October 6, 2020 13:55
@ofborg ofborg bot requested a review from 7c6f434c October 6, 2020 13:59
@siraben siraben changed the title ogre: 1.12.1 -> 1.12.9 ogre: 1.12.1 -> 1.12.9, cegui: enable build on darwin Oct 8, 2020
SuperSandro2000
SuperSandro2000 requested changes Nov 27, 2020
View reviewed changes
pkgs/development/libraries/cegui/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/cegui/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/ogre/1.10.x.nix
, withSamples ? false
, writeScriptBin
, rsync
, libobjc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be needed with Foundation.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed because the build fails when it could not find libobjc.

@SuperSandro2000
Copy link
Member

Fails to build on linux:

-- Configuring done
CMake Error at Components/Overlay/CMakeLists.txt:42 (add_library):
  Cannot find source file:

    /build/source/build/imgui-1.77/imgui.cpp

  Tried extensions .c .C .c++ .cc .cpp .cxx .cu .m .M .mm .h .hh .h++ .hm
  .hpp .hxx .in .txx


CMake Error at Components/Overlay/CMakeLists.txt:42 (add_library):
  No SOURCES given to target: OgreOverlay


CMake Generate step failed.  Build files cannot be regenerated correctly.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Dec 14, 2020
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 99727 run on x86_64-darwin 1

1 package failed to build:
  • ogre
2 packages built:
  • cegui
  • ogre1_10
-- Configuring done
CMake Error at Components/Overlay/CMakeLists.txt:42 (add_library):
  Cannot find source file:

    /tmp/nix-build-ogre-1.12.9.drv-0/source/build/imgui-1.77/imgui.cpp

  Tried extensions .c .C .c++ .cc .cpp .cxx .cu .m .M .mm .h .hh .h++ .hm
  .hpp .hxx .in .txx .f .F .for .f77 .f90 .f95 .f03 .ispc


CMake Error at Components/Overlay/CMakeLists.txt:42 (add_library):
  No SOURCES given to target: OgreOverlay


CMake Generate step failed.  Build files cannot be regenerated correctly.

@siraben siraben marked this pull request as draft December 20, 2020 17:12
@stale
Copy link

stale bot commented Oct 12, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 12, 2021
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 4, 2022
@siraben siraben marked this pull request as ready for review April 4, 2022 02:49
@siraben
Copy link
Member Author

siraben commented Apr 4, 2022

Result of nixpkgs-review pr 99727 run on aarch64-darwin 1

3 packages failed to build:
  • cegui
  • ogre
  • ogre1_10

@siraben siraben marked this pull request as draft April 4, 2022 03:15
@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 1, 2022
@wegank wegank mentioned this pull request Jan 2, 2023
Merged
13 tasks
@wegank wegank closed this Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: darwin Running or building packages on Darwin 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@siraben @SuperSandro2000 @wegank