key: init at 2.6.3 #99761
key: init at 2.6.3 #99761
Conversation
| , jre | ||
| , makeWrapper | ||
| , runCommand | ||
| , key |
There was a problem hiding this comment.
Not sure if that's a good idea, but it gets the job done without a callPackage (which essentially does the same thing...)
There was a problem hiding this comment.
The tricky bit is if you'd pkgs.key.override x and use it directly without inserting it into pkgs by means of an overlay, you'd have to do something like let key = pkgs.key.override (x // { inherit key; }; in key.
Instead, you could do
let gitRevision = # ...
key = stdenv.mkDerivation rec {
# ...
passthru.tests.check-version = /* ... */; # syntactically unchanged but uses the local binding
}
in key
There was a problem hiding this comment.
don't we basically have the same problem with all nixosTests?
There was a problem hiding this comment.
That's true. Doesn't mean this package can't do better, but I'll leave it up to you.
EDIT: tone :)
|
Result of 1 package built:
|
|
Result of 1 package built:
|
Motivation for this change
Using this at uni. Looks established and maintained enough
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)