New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need WebSocket library for WebDriver BiDi tests #26015
Comments
Thanks for filing this! cc @web-platform-tests/wpt-core-team The main things we will need here are to bring a websocket client library into WPT, and to extend the client in For a websocket client library, here are a few random choices I pulled from the internet:
Big choice seems to be - would |
Making a decision here definitely requires an RFC about any new dependency and about the proposed API surface. On the library question, I would take the position that we can accept Py3-only dependencies at this time. I think given the relevant timescales and the fact that vendors can already support both Py2 and Py3 we should choose the library we want rather than the one that happens to work with Python 2. I think designing the interaction with the existing WebDriver client is not going to be terribly problematic either way; the entrypoint to bidi is pretty clearly defined so it's not like lots of the exisiting code will be affected. There will just be some mechanism to get a bidi connection from a session. |
@k7z45 - do you have the time to own doing some experimentation with some of the websocket libraries above in WPT, to see what a client might look like? In particular it seems like deciding whether the I'm happy to support you from the WPT side with getting setup, consulting on any problems you have with our infrastructure, etc. |
I think myself and @jgraham are strongly in favour of a library using |
@stephenmcgruer
I think these examples will be standalone(outside of WPT). |
Right now we have pywebsocket3 as a websocket server in wpt. Is there a desire to replace pywebsocket3? |
@k7z45 - I think the more useful thing would be to try them within WPT, basically building a prototype for the RFC to point at. Given the multiple requests for using
@zcorpan - At the moment, I consider that out of scope. If we used something like https://github.com/aaugustin/websockets/ we could build our own websocket server on top of it (i.e. integrate it into wptserve), but that would have to wait until Q2 2021 (py3-only timeline). |
Got it, will sync with you. |
WebSocket BiDi protocol relies on WebSocket to initialize connection.
We would need a WebSocket client for python to write client code to connect to WebDriver webSocketUrl.
The initial Bidi(bidirectional) tests will focus on making the connection and verifying that for each session there can only be one WebSocket connection.
The test could live in /webdriver or /webdriver-bidi.
The text was updated successfully, but these errors were encountered: