Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_1password-gui: 0.8.8-1 -> 0.8.9 #99729

Merged
merged 1 commit into from Oct 6, 2020
Merged

_1password-gui: 0.8.8-1 -> 0.8.9 #99729

merged 1 commit into from Oct 6, 2020

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Oct 6, 2020

Motivation for this change

Changelog:

https://1password.community/discussion/116148/1password-development-preview-0-8-9

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

timstott
timstott approved these changes Oct 6, 2020
View reviewed changes
Copy link
Contributor

@timstott timstott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Tested on NixOS

@danieldk
Copy link
Contributor Author

danieldk commented Oct 6, 2020

+1 Tested on NixOS

Thanks for testing!

@danieldk danieldk merged commit 4e1b68b into NixOS:master Oct 6, 2020
@danieldk danieldk deleted the 1password-gui-0.8.9 branch October 6, 2020 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timstott timstott timstott approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danieldk @timstott