Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gmrender-resurrect: Make build against libupnp 1.14 ok #99899

Merged
merged 1 commit into from Oct 7, 2020

Conversation

ardumont
Copy link
Contributor

@ardumont ardumont commented Oct 6, 2020

Related to #93048

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions: debian with nix
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nixpkgs-review pr 99899 [2]
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size: -1136 [1]
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

[1]

before /nix/store/vmr8ny2pwaa6jdnrq14yml0b58cbs0xi-gmrender-resurrect-0.0.8      813998272
after  /nix/store/m8vmfyly18zx3wzx881fmhx7v2wkvqgc-gmrender-resurrect-0.0.8      813999408

[2]

$ nixpkgs-review pr 99899
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0 pull/99899/head:refs/nixpkgs-review/1
remote: Enumerating objects: 59, done.
remote: Counting objects: 100% (59/59), done.
remote: Total 101 (delta 59), reused 59 (delta 59), pack-reused 42
Receiving objects: 100% (101/101), 190.48 KiB | 241.00 KiB/s, done.
Resolving deltas: 100% (72/72), completed with 50 local objects.
From https://github.com/NixOS/nixpkgs
   0093e4e6a99..9ae60c87474  master               -> refs/nixpkgs-review/0
 + 024ad57ed18...98e5369bafa refs/pull/99899/head -> refs/nixpkgs-review/1  (forced update)
$ git worktree add /home/tony/.cache/nixpkgs-review/pr-99899/nixpkgs 9ae60c874749f2bdbfb1ffb1249621f050410ad7
Preparing worktree (detached HEAD 9ae60c87474)
Updating files: 100% (22850/22850), done.
HEAD is now at 9ae60c87474 act: build with go 1.15 on darwin
$ git merge --no-commit 98e5369bafacf919982813d86e5dc99095d5d3d0
Automatic merge went well; stopped before committing as requested
$ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /home/tony/.cache/nixpkgs-review/pr-99899/build.nix
building '/nix/store/97ijw7dfydq4npnv8hc6b13fdvm72hl4-env.drv'...
[1 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/99899
1 package built:
gmrender-resurrect

$ nix-shell /home/tony/.cache/nixpkgs-review/pr-99899/shell.nix

[nix-shell:~/.cache/nixpkgs-review/pr-99899]$ exit
$ git worktree prune

@ardumont ardumont mentioned this pull request Oct 6, 2020
10 tasks
@ashkitten
Copy link
Contributor

not actively using this rn so can't test but if it works then lgtm

@timokau timokau merged commit b3af4a4 into NixOS:master Oct 7, 2020
@ardumont ardumont deleted the bump-gmrender-resurrect branch October 7, 2020 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants