firefox: ensure pipewire is only enabled with wayland & webrtc #99902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that we aren't applying any of the experiemental pipewire patches when the dependencies aren't enabled. As of now pipewire only works with wayland and webrtc. If either of them are not activated we can't build with pipewireSupport and we should not.
kvtb
reviewed
Jan 1, 2021
| @@ -69,6 +70,7 @@ | |||
| }: | |||
|
|
|||
| assert stdenv.cc.libc or null != null; | |||
| assert pipewireSupport -> !waylandSupport || !webrtcSupport -> throw "pipewireSupport requires both wayland and webrtc support."; | |||
There was a problem hiding this comment.
assert pipewireSupport -> ((!waylandSupport || !webrtcSupport) -> throw "pipewireSupport requires both wayland and webrtc support.");
it is difficult to read without braces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This ensures that we aren't applying any of the experiemental pipewire
patches when the dependencies aren't enabled. As of now pipewire only
works with wayland and webrtc. If either of them are not activated we
can't build with pipewireSupport and we should not.
This is the follow-up to the changes I added to #99692.
Things done
firefoxwith pipewire and without, ensured that wayland & webrtc must be on for eval to succeed