Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.localzone: 0.9.6 -> 0.9.7 #99886

Merged
merged 1 commit into from Oct 6, 2020
Merged

python3Packages.localzone: 0.9.6 -> 0.9.7 #99886

merged 1 commit into from Oct 6, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 6, 2020 •
edited

Motivation for this change

fixes build with dnspython >= 2

related: #99567 ags-slc/localzone#1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer requested a review from FRidh as a code owner October 6, 2020 18:51
@jonringer jonringer added the 9.needs: port to stable A PR needs a backport to the stable release. label Oct 6, 2020
@jonringer
Copy link
Contributor Author

this is still broken on release-20.09

@jonringer
Copy link
Contributor Author 

https://github.com/NixOS/nixpkgs/pull/99886
4 packages built:
lexicon python27Packages.localzone python37Packages.localzone python38Packages.localzone

@jonringer jonringer merged commit 0093e4e into NixOS:master Oct 6, 2020
@jonringer jonringer deleted the bump-localzone branch October 6, 2020 18:55
This was referenced Oct 6, 2020
Closed
Merged
@jonringer jonringer added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jonringer