Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shattered-pixel-dungeon: 0.8.2d -> 0.9.0b #99885

Merged
merged 2 commits into from Jan 20, 2021
Merged

shattered-pixel-dungeon: 0.8.2d -> 0.9.0b #99885

merged 2 commits into from Jan 20, 2021

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Oct 6, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@roberth
Copy link
Member

roberth commented Nov 5, 2020

@GrahamcOfBorg build shattered-pixel-dungeon.passthru.tests

@fgaz
Copy link
Member Author

fgaz commented Nov 5, 2020

Uh... looks like the 0.9.0 tag was deleted :-/ :-/ :-/

I'm sure I didn't mistype it because I still have a 0.9.0 build in my cache

@fgaz fgaz force-pushed the shattered-pixel-dungeon/0.9.0 branch from 25800a4 to ec61ccd Compare November 5, 2020 15:10
@fgaz fgaz changed the title shattered-pixel-dungeon: 0.8.2d -> 0.9.0 shattered-pixel-dungeon: 0.8.2d -> 0.9.0b Nov 5, 2020
@fgaz
Copy link
Member Author

fgaz commented Nov 5, 2020

Updated to 0.9.0b

@fgaz
Copy link
Member Author

fgaz commented Nov 5, 2020

Weird null pointer runtime error only on arm:

Exception: java.lang.NullPointerException thrown from the UncaughtExceptionHandler in thread "main"

I wonder if it happens every time. Let's see

@GrahamcOfBorg build shattered-pixel-dungeon.passthru.tests

@fgaz fgaz mentioned this pull request Nov 20, 2020
Merged
3 tasks
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 99885 run on x86_64-linux 1

1 package built:
  • shattered-pixel-dungeon

@SuperSandro2000
Copy link
Member

Fails on darwin with

building

FAILURE: Build failed with an exception.

* What went wrong:
Could not open terminal for stdout: could not get termcap entry

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

@fgaz
Copy link
Member Author

fgaz commented Dec 2, 2020

@SuperSandro2000 could you try to rebuild on darwin?

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Dec 3, 2020 •
edited

@fgaz please fix the eval error

37|       # https://github.com/gradle/gradle/issues/4426
38|       ${optionalString stdenv.isDarwin "export TERM=dumb"}
|         ^
39|       gradle --no-daemon desktop:release
undefined variable 'optionalString'

@fgaz fgaz force-pushed the shattered-pixel-dungeon/0.9.0 branch from 7fa6cb6 to b40dbe2 Compare December 3, 2020 15:28
@fgaz
Copy link
Member Author

fgaz commented Dec 3, 2020

Sorry, I forgot to eval before pushing. here we go.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 99885 run on x86_64-linux 1

1 package built:
  • shattered-pixel-dungeon

@SuperSandro2000
Copy link
Member

Please fix it for darwin or mark it broken:

building

Welcome to Gradle 5.6.4!

Here are the highlights of this release:
 - Incremental Groovy compilation
 - Groovy compile avoidance
 - Test fixtures for Java projects
 - Manage plugin versions via settings script

For more details see https://docs.gradle.org/5.6.4/release-notes.html

To honour the JVM settings for this build a new JVM will be forked. Please consider using the daemon: https://docs.gradle.org/5.6.4/userguide/gradle_daemon.html.

FAILURE: Build failed with an exception.

* What went wrong:
Unable to start the daemon process.
This problem might be caused by incorrect configuration of the daemon.
For example, an unrecognized jvm option is used.
Please refer to the User Manual chapter on the daemon at https://docs.gradle.org/5.6.4/userguide/gradle_daemon.html
Process command line: /nix/store/3z6qbniycq9pvx8wbls08y89y0zf44m8-zulu1.8.0_202-8.36.0.1/bin/java -XX:MaxPermSize=512m -XX:+HeapDumpOnOutOfMemoryError -Xmx2048m -Dfile.encoding=UTF-8 -Duser.country=US -Duser.language=en -Duser.variant -cp /nix/store/3pl1pfdffk5l3406pa7kzylm9m2s5fda-gradle-5.6.4/lib/gradle/lib/gradle-launcher-5.6.4.jar org.gradle.launcher.daemon.bootstrap.GradleDaemon 5.6.4
Please read the following process output to find out more:
-----------------------
OpenJDK 64-Bit Server VM warning: ignoring option MaxPermSize=512m; support was removed in 8.0


* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

@fgaz
shattered-pixel-dungeon: almost fix darwin build
61b83e6 
Gradle has some problems with termcap:

> FAILURE: Build failed with an exception.
>
> * What went wrong:
> Could not open terminal for stdout: could not get termcap entry

see gradle/gradle#4426

Unfortunately before the merge darwin broke again, so while this is now
in a better state it is still broken:
NixOS#99885 (comment)
@fgaz fgaz force-pushed the shattered-pixel-dungeon/0.9.0 branch 2 times, most recently from 1ec4be6 to 61b83e6 Compare January 20, 2021 10:30
@fgaz
Copy link
Member Author

fgaz commented Jan 20, 2021

Broken it is then

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 99885 run on x86_64-linux 1

1 package built:
  • shattered-pixel-dungeon

@SuperSandro2000 SuperSandro2000 merged commit f0cf05c into NixOS:master Jan 20, 2021
@fgaz fgaz deleted the shattered-pixel-dungeon/0.9.0 branch January 20, 2021 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fgaz @roberth @SuperSandro2000