Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] effitask: fix build #99362

Merged
merged 1 commit into from Oct 3, 2020
Merged

[20.09] effitask: fix build #99362

merged 1 commit into from Oct 3, 2020

Conversation

mdevlamynck
Copy link
Contributor

Motivation for this change

backport of #99238
ZHF: #97479
(cherry picked from commit ab0e7bf)
@NixOS/nixos-release-managers

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mdevlamynck
effitask: fix build
ed6a21f 
(cherry picked from commit ab0e7bf)
@ofborg ofborg bot requested a review from davidak October 2, 2020 10:00
davidak
davidak approved these changes Oct 2, 2020
View reviewed changes
Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, works

thanks for backporting ✨

@mdevlamynck
Copy link
Contributor Author

Just following the process ^^

@risicle
Copy link
Contributor

risicle commented Oct 3, 2020

Yup, WFM macos 10.14

@risicle risicle merged commit 8d6f5be into NixOS:release-20.09 Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidak davidak davidak approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mdevlamynck @risicle @davidak