vlc: change name for library only version #99346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterhoeg
changed the title
worldofpeace
approved these changes
Oct 2, 2020
worldofpeace
reviewed
Oct 2, 2020
| @@ -24,7 +24,7 @@ with stdenv.lib; | |||
| assert (withQt5 -> qtbase != null && qtsvg != null && qtx11extras != null && wrapQtAppsHook != null); | |||
|
|
|||
| stdenv.mkDerivation rec { | |||
| pname = "vlc"; | |||
| pname = "${optionalString onlyLibVLC "lib"}vlc"; | |||
There was a problem hiding this comment.
won't this break the download below since it uses pname for the archive?
|
won't this break the download below since it uses pname for the archive?
Absolutely - what on earth did I compile then....
Fixed.
|
The archive isn't re-downloaded when the url changes; only when the sha256 changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Very minor cleanup, but it does make nix-store --query --referrers
easier to grok when both the library and actual application are showing.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)