New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tabnine: fix build #99312
tabnine: fix build #99312
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can't modify another derivation, they are read-only
error: build of '/nix/store/d3n235cb5shqdj3p5k937mb84fn7pd8k-tabnine-3.1.1.drv' on 'ssh://build' failed: builder for '/nix/store/d3n235cb5shqdj3p5k937mb84fn7pd8k-tabnine-3.1.1.drv' failed with exit code 1
builder for '/nix/store/d3n235cb5shqdj3p5k937mb84fn7pd8k-tabnine-3.1.1.drv' failed with exit code 1; last 6 log lines:
patching sources
configuring
no configure script, doing nothing
installing
chmod: changing permissions of '/nix/store/0l29blcimkb75b87r1xqlri6sqba198p-TabNine': Operation not permitted
builder for '/nix/store/d3n235cb5shqdj3p5k937mb84fn7pd8k-tabnine-3.1.1.drv' failed with exit code 1
please build the package
weird it works for me in both darwin and linux. |
Result of 2 packages built:
|
@GrahamcOfBorg build tabnine |
also, this doesn't work for darwin. It's just "succeeding" due to how fixed-output-derivations work |
Maybe it's something with my local nix setup, but it not just builds but correctly works on my machine (TabNine binary works as well as tabnine completion inside vim). |
do you use a mac or linux? |
I use mac with nix and also checked on debian with nix. |
it worked on both machines even before replacing chmod+ln with cp+chmod |
|
your nix-store should be read-only. chmod'ing another store path should fail |
That's for package version which does chmod $src and then ln -s on macos:
onsails@7e9dc15 |
That's the same on debian with nix:
|
Perhaps nix store is read-only on NixOS only. |
@GrahamcOfBorg build tabnine |
This likely means that you're not using a sandbox, and nixos by default will use a sandbox. Either way, going to close in favor of #99310 I brought over the fixes for darwin |
Motivation for this change
#99264 is broken on linux
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)