Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zfsUnstable: 2.0.0-rc2 -> 2.0.0-rc3 #99361

Merged
merged 1 commit into from Oct 2, 2020
Merged

zfsUnstable: 2.0.0-rc2 -> 2.0.0-rc3 #99361

merged 1 commit into from Oct 2, 2020

Conversation

hmenke
Copy link
Member

@hmenke hmenke commented Oct 2, 2020

Motivation for this change

More bugfixes: https://github.com/openzfs/zfs/releases/tag/zfs-2.0.0-rc3

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@hmenke
Copy link
Member Author

hmenke commented Oct 2, 2020

Result of nixpkgs-review pr 99361 1

18 packages built:
  • linuxPackages-libre.zfsUnstable
  • linuxPackages.zfsUnstable
  • linuxPackages_4_14.zfsUnstable
  • linuxPackages_4_19.zfsUnstable
  • linuxPackages_4_4.zfsUnstable
  • linuxPackages_4_9.zfsUnstable
  • linuxPackages_5_7.zfsUnstable
  • linuxPackages_5_8.zfsUnstable
  • linuxPackages_hardened.zfsUnstable
  • linuxPackages_latest-libre.zfsUnstable
  • linuxPackages_latest_hardened.zfsUnstable
  • linuxPackages_latest_xen_dom0.zfsUnstable
  • linuxPackages_latest_xen_dom0_hardened.zfsUnstable
  • linuxPackages_testing_bcachefs.zfsUnstable
  • linuxPackages_xen_dom0.zfsUnstable
  • linuxPackages_xen_dom0_hardened.zfsUnstable
  • linuxPackages_zen.zfsUnstable
  • zfsUnstable

@hmenke
Copy link
Member Author

hmenke commented Oct 2, 2020

@ofborg test zfs.unstable

@hmenke
Copy link
Member Author

hmenke commented Oct 2, 2020

Maintainers: @jcumming @wizeman @fpletz @globin

@jonringer @clefru

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

tests pass

@jonringer jonringer merged commit 952b698 into NixOS:master Oct 2, 2020
@hyperfekt
Copy link
Contributor

hyperfekt commented Oct 9, 2020

Should this be backported (maybe after the 20.09 release)?

@jonringer
Copy link
Contributor

generally I would say no, but it's explicit about itself being unstable.

Seeing as most of the changes are bugfixes, I would say yes

@jonringer jonringer added the 9.needs: port to stable A PR needs a backport to the stable release. label Oct 9, 2020
@hyperfekt
Copy link
Contributor

hyperfekt commented Oct 9, 2020

Well, rc2 is part of 20.09 as the unstable version, so that decision seems to have been made already. ^^

@clefru
Copy link
Contributor

clefru commented Oct 10, 2020

I think that zfsUnstable inside the release branch exists because we also add new kernels to the release branch, and zfs (stable) was not that good in supporting new kernels, so people saw a need to use zfs unstable. That has changed, as the stable zfs branch is pretty good in support new kernels.

But yes, -rc3 should be backported, given the precedent with 2.0.0-rc1/rc2. The real question is what we do when 2.0.0 stable gets released :). Do we go back and make zfsUnstable track the zfs master branch?

@hmenke
Copy link
Member Author

hmenke commented Oct 10, 2020

@clefru In the past, zfs and zfsUnstable were just the same when there were no release candidates out. However, I expect there to be more beta updates in the future as OpenZFS wants to switch to a yearly release cycle.

@TredwellGit TredwellGit added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants