Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libetpan: 1.9.3 -> 1.9.4 #99332

Merged
merged 1 commit into from Jan 19, 2021
Merged

libetpan: 1.9.3 -> 1.9.4 #99332

merged 1 commit into from Jan 19, 2021

Conversation

oxzi
Copy link
Member

@oxzi oxzi commented Oct 1, 2020

Also added myself as a maintainer because there are none.

Motivation for this change

Update libetpan to its latest release. Also added myself as a maintainer because there are none.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

danieldk
danieldk suggested changes Oct 2, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking up maintainership! Added two suggested changes.

pkgs/development/libraries/libetpan/default.nix Show resolved Hide resolved
pkgs/development/libraries/libetpan/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 99332 run on x86_64-linux 1

4 packages built:
  • claws-mail
  • claws-mail-gtk3
  • libetpan
  • mailcore2

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

mailcore2:

Please consider this feature to be alpha.

A substituteInPlace with an unused --replace got detected:

substituteStream(): WARNING: pattern 'tidy/tidy.h' doesn't match anything in file 'CMakeLists.txt'

Please check the offending substituteInPlace for typos or changes in source.

@oxzi
libetpan: 1.9.3 -> 1.9.4
a38b1c6 
Also added myself as a maintainer because there are none.
@SuperSandro2000 SuperSandro2000 merged commit bc3aef8 into NixOS:master Jan 19, 2021
@oxzi oxzi deleted the libetpan-v1.9.4 branch January 19, 2021 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk requested changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oxzi @SuperSandro2000 @danieldk