Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.sqlite-utils: init at 2.22 #99359

Merged
merged 2 commits into from Nov 6, 2020
Merged

pythonPackages.sqlite-utils: init at 2.22 #99359

merged 2 commits into from Nov 6, 2020

Conversation

meatcar
Copy link
Contributor

@meatcar meatcar commented Oct 2, 2020

Motivation for this change

Adding a useful tool for tweaking sqlite dbs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@meatcar meatcar changed the title pythonPackages.sqlite-utils: init at 2.21 pythonPackages.sqlite-utils: init at 2.22 Oct 27, 2020
@meatcar
Copy link
Contributor Author

meatcar commented Oct 27, 2020

@jonringer thanks for the review, I implemented your suggestions. Also bumped up to v2.22 that was released since.

Is there anything else I should do to help this PR get merged?

Pamplemousse
Pamplemousse approved these changes Oct 28, 2020
View reviewed changes
Copy link
Member

@Pamplemousse Pamplemousse left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Built and tested on NixOS: application starts and displays help, library imported without error in Python.

@srhb srhb merged commit e3bbada into NixOS:master Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@Pamplemousse Pamplemousse Pamplemousse approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@meatcar @Pamplemousse @jonringer @srhb