nixos: Conform with RFC 1123 in networking.hostName #99329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x4A6F
force-pushed
the
master-networking-hostname
branch
from
834f62c
to
5e9589d
Compare
0x4A6F
changed the title
Conform to RFC 1123 [0], specifically to "2.1 Host Names and Numbers", which allow starting host name with alphanumerical instead of alphabetical characters. RFC 1123 updates RFC 952 [1], which is referenced in "man 5 hosts". [0]: https://tools.ietf.org/html/rfc1123 [1]: https://tools.ietf.org/html/rfc952
0x4A6F
force-pushed
the
master-networking-hostname
branch
from
5e9589d
to
c232d4b
Compare
primeos
approved these changes
Oct 2, 2020
There was a problem hiding this comment.
RFC 1123 updates RFC 952
The way I see it is that they're different "standards" (domain names vs. requirements for Internet hosts) and RFC 1123 isn't listed as an update of RFC 1035 (but I didn't read them so I might be missing something). However, it still seems to be considered an amendment or even update depending on the source.
But in any case I'm fine with this change (RFC 1123 seems more appropriate) though I'm not sure if we really need it and if e.g. some (old) software might misbehave if the hostname starts with a digit.
I'll give this a slight approval but I don't want to make the final decision here.
flokli
approved these changes
Oct 2, 2020
|
Backported to 20.09 in c232d4b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
also see #94011.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)cc: @zimbatm @primeos